Category 'build' errors found when checking by task_lint

Hi There,

I follow the coding styles check of dgl document by bash tests/scripts/task_lint.sh but there are some errors on cpp part even I never touch cpp code. The details are like this:


Checking code style of C++ codes…
include/dgl/immutable_graph.h:60: Add #include for shared_ptr<> [build/include_what_you_use] [4]
include/dgl/graph_interface.h:57: Add #include for shared_ptr<> [build/include_what_you_use] [4]
include/dgl/runtime/packed_func.h:1136: Add #include for forward [build/include_what_you_use] [4]
src/c_api_common.cc:31: Add #include for move [build/include_what_you_use] [4]
src/graph/network/serialize.cc:142: Add #include for make_shared<> [build/include_what_you_use] [4]
src/runtime/file_util.cc:133: Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
src/runtime/file_util.h:73: Add #include <unordered_map> for unordered_map<> [build/include_what_you_use] [4]
src/runtime/module_util.cc:47: Add #include for shared_ptr<> [build/include_what_you_use] [4]
src/runtime/module_util.h:28: Add #include for shared_ptr<> [build/include_what_you_use] [4]
src/runtime/workspace_pool.cc:115: Add #include for shared_ptr<> [build/include_what_you_use] [4]
src/runtime/workspace_pool.h:56: Add #include for shared_ptr<> [build/include_what_you_use] [4]
=====26/32 cpp-header files passed check=====
include/dgl/immutable_graph.h: 1 Errors of 1 Categories map={‘build’: 1}
include/dgl/graph_interface.h: 1 Errors of 1 Categories map={‘build’: 1}
include/dgl/runtime/packed_func.h: 1 Errors of 1 Categories map={‘build’: 1}
src/runtime/file_util.h: 1 Errors of 1 Categories map={‘build’: 1}
src/runtime/module_util.h: 1 Errors of 1 Categories map={‘build’: 1}
src/runtime/workspace_pool.h: 1 Errors of 1 Categories map={‘build’: 1}
=====23/28 cpp-soruce files passed check=====
src/c_api_common.cc: 1 Errors of 1 Categories map={‘build’: 1}
src/graph/network/serialize.cc: 1 Errors of 1 Categories map={‘build’: 1}
src/runtime/file_util.cc: 1 Errors of 1 Categories map={‘build’: 1}
src/runtime/module_util.cc: 1 Errors of 1 Categories map={‘build’: 1}
src/runtime/workspace_pool.cc: 1 Errors of 1 Categories map={‘build’: 1}
11 files failed lint
Done processing include/dgl/graph.h
Done processing include/dgl/graph_op.h
Done processing include/dgl/immutable_graph.h
Category ‘build’ errors found: 1
Total errors found: 1
Done processing include/dgl/nodeflow.h
Done processing include/dgl/scheduler.h
Done processing include/dgl/graph_interface.h
Category ‘build’ errors found: 1
Total errors found: 1
Done processing include/dgl/sampler.h
Done processing include/dgl/runtime/c_backend_api.h
Done processing include/dgl/runtime/c_runtime_api.h
Done processing include/dgl/runtime/device_api.h
Done processing include/dgl/runtime/module.h
Done processing include/dgl/runtime/ndarray.h
Done processing include/dgl/runtime/packed_func.h
Category ‘build’ errors found: 1
Total errors found: 1
Done processing include/dgl/runtime/registry.h
Done processing include/dgl/runtime/serializer.h
Done processing include/dgl/runtime/threading_backend.h
Done processing include/dgl/runtime/util.h
Done processing src/c_api_common.cc
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/c_api_common.h
Done processing src/graph/graph.cc
Done processing src/graph/graph_op.cc
Done processing src/graph/immutable_graph.cc
Done processing src/graph/nodeflow.cc
Done processing src/graph/traversal.cc
Done processing src/graph/traversal.h
Done processing src/graph/graph_apis.cc
Done processing src/graph/network.cc
Done processing src/graph/network.h
Done processing src/graph/randomwalk.cc
Done processing src/graph/sampler.cc
Done processing src/graph/network/communicator.h
Done processing src/graph/network/msg_queue.cc
Done processing src/graph/network/msg_queue.h
Done processing src/graph/network/serialize.cc
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/graph/network/serialize.h
Done processing src/graph/network/socket_communicator.cc
Done processing src/graph/network/socket_communicator.h
Done processing src/graph/network/tcp_socket.cc
Done processing src/graph/network/tcp_socket.h
Done processing src/runtime/c_runtime_api.cc
Done processing src/runtime/cpu_device_api.cc
Done processing src/runtime/dso_module.cc
Done processing src/runtime/file_util.cc
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/runtime/file_util.h
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/runtime/meta_data.h
Done processing src/runtime/module.cc
Done processing src/runtime/module_util.cc
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/runtime/module_util.h
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/runtime/ndarray.cc
Done processing src/runtime/pack_args.h
Done processing src/runtime/registry.cc
Done processing src/runtime/runtime_base.h
Done processing src/runtime/system_lib_module.cc
Done processing src/runtime/thread_pool.cc
Done processing src/runtime/thread_storage_scope.h
Done processing src/runtime/threading_backend.cc
Done processing src/runtime/workspace_pool.cc
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/runtime/workspace_pool.h
Category ‘build’ errors found: 1
Total errors found: 1
Done processing src/scheduler/scheduler.cc
Done processing src/scheduler/scheduler_apis.cc


Does anyone know what’s the problem?

Hi,

I’m not sure about the problem. However, it seems you don’t need to worry about this because your commit has passed our Jenkins CI.

It might because of the cpp_lint version. What’s your version?

cpplint 1.4.4
centos 7.4.1708

I see, that’s a good news :slight_smile: